Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our async IO traits have methods that receive an owned buffer (in the form of
BytesMut
) and return anio::Result<BytesMut>
which gives the buffer back at the end.The trouble is, in the case of an error the buffer will leak. This is not a problem yet since we currently allocate a fresh buffer for every IO operation, but as we move toward buffer pools and completion-based IO operations, we don't want to leak these buffers when IO errors occur.
This PR makes a new
BufResult<T>
which is just a(io::Result<T>, BytesMut)
to ensure that you always return ownership of the buffer to the caller even in the event of IO failures.Currently this doesn't change any behavior, but when we swtich to pre-allocated buffers and IO operations using those, it will matter.