Skip to content

Don't fail entire test-pypi deploys on AppInspect failing #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ickerday merged 3 commits into from
Aug 25, 2026
Merged

Don't fail entire test-pypi deploys on AppInspect failing #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c393be7
Don't fail entire test-pypi deploys on AppInspect failing
Ickerday Aug 25, 2026
699f815
Disable AppInspect in PRs, fix warnings
Ickerday Aug 25, 2026
7cf6e73
Reenable AppInspect in PRs
Ickerday Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/appinspect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
persist-credentials: false
- uses: ./.github/actions/setup-sdk-environment
with:
python-version: 3.13
deps-group: lint
- name: Run AppInspect
uses: ./.github/actions/run-appinspect
3 changes: 2 additions & 1 deletion .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

permissions: {}
Expand Down Expand Up @@ -51,6 +51,7 @@ jobs:
- name: Build packages for distribution
run: uv build
- name: Run AppInspect
if: startsWith(github.ref, 'refs/tags/') == true
uses: ./.github/actions/run-appinspect
- name: Upload distributables
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
persist-credentials: false
- uses: ./.github/actions/setup-sdk-environment
with:
python-version: ${{ matrix.python-version }}
deps-group: lint
- name: Verify uv.lock is up-to-date
run: uv lock --check
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.13]
splunk-version: [latest]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
with:
persist-credentials: false
- uses: ./.github/actions/setup-sdk-environment
with:
python-version: ${{ matrix.python-version }}
deps-group: test
- name: Download Splunk MCP Server App
continue-on-error: true
Expand Down Expand Up @@ -57,8 +55,8 @@ jobs:
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9
with:
path: .pytest_cache
key: pytest-cache-${{ runner.os }}-py${{ matrix.python-version }}-${{ github.ref_name }}-${{ github.sha }}
restore-keys: pytest-cache-${{ runner.os }}-py${{ matrix.python-version }}-${{ github.ref_name }}-
key: pytest-cache-${{ runner.os }}-${{ github.ref_name }}-${{ github.sha }}
restore-keys: pytest-cache-${{ runner.os }}-${{ github.ref_name }}-
- name: Run unit tests
run: make test-unit
- name: Run integration/system tests
Expand Down
Loading