Skip to content

Commit

Permalink
Apply @dlstadther's suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
progval authored Oct 21, 2023
1 parent bda147c commit db92ba7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion luigi/contrib/mongodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __init__(self, mongo_client, index, collection):
self._collection = collection

def __str__(self):
return '%s/%s' % (self._index, self._collection)
return f'{self._index}/{self._collection}'

Check warning on line 39 in luigi/contrib/mongodb.py

View check run for this annotation

Codecov / codecov/patch

luigi/contrib/mongodb.py#L39

Added line #L39 was not covered by tests

def get_collection(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion luigi/contrib/sqla.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def __init__(self, connection_string, target_table, update_id, echo=False, conne
self.marker_table_bound = None

def __str__(self):
return self.marker_table_bound or self.connection_string
return self.target_table

Check warning on line 193 in luigi/contrib/sqla.py

View check run for this annotation

Codecov / codecov/patch

luigi/contrib/sqla.py#L193

Added line #L193 was not covered by tests

@property
def engine(self):
Expand Down
2 changes: 1 addition & 1 deletion luigi/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def run(self):
if not self.check_complete(dep):
nonexistent_outputs = [output for output in dep.output() if not output.exists()]
if nonexistent_outputs:
missing.append('%s (%s)' % (dep.task_id, ', '.join(map(str, nonexistent_outputs))))
missing.append(f'{dep.task_id} ({", ".join(map(str, nonexistent_outputs))})')

Check warning on line 190 in luigi/worker.py

View check run for this annotation

Codecov / codecov/patch

luigi/worker.py#L190

Added line #L190 was not covered by tests
else:
missing.append(dep.task_id)
if missing:
Expand Down

0 comments on commit db92ba7

Please sign in to comment.