Task list shell command will now work properly. #5407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An additional header of schemaType was added to task definitions. This caused the shell to crash with no exception. Also fixed tests in the DeployerPropertiesUtilTests.
corneil
approved these changes
Jul 20, 2023
corneil
added a commit
that referenced
this pull request
Jul 21, 2023
* First pass on TASK and BATCH updates. * Just polishing up some of the code as I was reading it. (#5388) * Now throws NoSuchSchemaTarget instead of NPE (#5390) * Now throws NoSuchSchemaTarget instead of NPE * When an invalid schema is specified. * Did some polishing * Just a little more polishing * Updated with boot 3 task and batches running, CTR launching boot 2 and boot 3 jobs. Shell executing to report jobs and lists. * Updated Shell commands for jobs. * Resolve job execution and job instance controllers. Updated documentation. * Updated usage of LaunchResponse and LaunchResponseResource * TaskJobExecution was using jobExecutionId for the taskExecutionID (#5399) The DefaultTaskJobTests (integration) will now pass. * Added tasks/executions/launch to support Boot 2 and Boot 3 tasks, while tasks/executions will only work for Boot 2 workloads. * Updated for launching and backward compatibility. * Fixed retrieval of Steps. * Updated ctr properties for task names / ids. * Clean up properties for tablePrefix on ctr tasks. * Fix the request parameters in TaskTemplate.launch * Refactored for warnings. * Refactored for warnings. * Fix deleting of child executions * Update prometheus-rsocket-proxy to 1.5.2 * Task List shell command will now work properly. (#5407) An additional header of schemaType was added to task definitions. This caused the shell to crash with no exception. Also fixed tests in the DeployerPropertiesUtilTests. * Update prometheus-rsocket-proxy to 1.5.2 Fix errors in tests for more arguments. Update ctr support for END and FAIL nodes. * Fix stackoverflow in findChildTasks. --------- Co-authored-by: Glenn Renfro <grenfro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute the following steps in SCDF Shel to reproduce the issue.
Bug
This steps above caused the shell to crash with no exception.
Cause
An additional header of
schemaTypewas added to task definitions.Additional fix