Launching the same CTR instance will now succeed #5415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Scenario** CTR launch with simple conditional statement that contains both Boot2 and Boot3 apps. Relaunch the CTR again it should succeed by default. ``` app register --bootVersion 3 --name timestamp3 --uri maven://io.spring:timestamp-task:3.0.0 --type task task create --name ctrseq --definition "timestamp && timestamp3" task launch --name ctrseq task list task execution list task execution status --id ctrseq task launch --name ctrseq task execution list task execution status --id ctrseq ``` The cause is SCDF stores the taskPrefix using both the composed-task-app-properties and the properties. While this works for the first execution, The second execution fails because it picks up a duplicate property for the taskPrefix. This is because on the first execution, it is stored in the manifest as a base64 value. So the solution is not to re-add the taskPrefix app properties and use just the composed-task-app-properties, which is used by CTR to determine which prefix to use and will be passed to the child app.
corneil
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario
CTR launch with simple conditional statement that contains both Boot2 and Boot3 apps. Relaunch the CTR again it should succeed by default.
The cause is SCDF stores the taskPrefix using both the composed-task-app-properties and the properties. While this works for the first execution,
The second execution fails because it picks up a duplicate property for the taskPrefix. This is because on the first execution, it is stored in the manifest as a base64 value.
So the solution is not to re-add the taskPrefix app properties and use just the composed-task-app-properties, which is used by CTR to determine which prefix to use and will be passed to the child app.
We can discuss if there is a better solution.