Add support for running Oracle locally on Apple ARM64 #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `local-dev-oracle` Maven profile that can be used to build a server jar that includes the Oracle database driver for local testing only. * Introduces SystemStubsExtension for setting testcontainers required env vars when running tests on Mac M * Decorates the OracleSmokeTest with the above which serves as an example of how to conditionally run an Oracle testcontainers test on Mac M. * In tandem, a new page was added to thw Wiki https://github.com/spring-cloud/spring-cloud-dataflow/wiki/Oracle-on-Mac-ARM64 Resolves spring-cloud#5539
onobc
commented
Nov 7, 2023
| @@ -409,5 +415,15 @@ | |||
| </pluginRepository> | |||
| </pluginRepositories> | |||
| </profile> | |||
| <profile> | |||
| <id>local-dev-oracle</id> | |||
There was a problem hiding this comment.
We already have a precedent for this technique in PRO for H2 dependency.
onobc
commented
Nov 7, 2023
...er/src/test/java/org/springframework/cloud/dataflow/server/db/migration/OracleSmokeTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
local-dev-oracleMaven profile that can be used to build a server jar that includes the Oracle database driver for local testing only.Introduces SystemStubsExtension for setting testcontainers required env vars when running tests on Mac M
Decorates the OracleSmokeTest with the above which serves as an example of how to conditionally run an Oracle testcontainers test on Mac M.
In tandem, a new page was added to thw Wiki https://github.com/spring-cloud/spring-cloud-dataflow/wiki/Oracle-on-Mac-ARM64
Resolves #5539