Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated DefaultTaskExecutionService constructor #6046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove deprecated DefaultTaskExecutionService constructor #6046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dbcd2
Remove deprecated constructor
cppwfs Nov 5, 2024
0d9b408
Add deprecation removal note to whats-new doc
cppwfs Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions ...a/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskExecutionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,64 +166,6 @@ public class DefaultTaskExecutionService implements TaskExecutionService {
"or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', " +
"or 'abc-123')";

/**
* Initializes the {@link DefaultTaskExecutionService}.
*
* @param propertyResolver the spring application context
* @param launcherRepository the repository of task launcher used to launch task apps.
* @param auditRecordService the audit record service
* @param taskRepository the repository to use for accessing and updating task executions
* @param taskExecutionInfoService the service used to setup a task execution
* @param taskDeploymentRepository the repository to track task deployment
* @param taskDefinitionRepository the repository to query the task definition
* @param taskExecutionRepositoryService the service used to create the task execution
* @param taskAppDeploymentRequestCreator the task app deployment request creator
* @param taskExplorer the task explorer
* @param dataflowTaskExecutionDao the dataflow task execution dao
* @param dataflowTaskExecutionMetadataDao repository used to manipulate task manifests
* @param dataflowTaskExecutionQueryDao repository to query aggregate TaskExecution data
* @param oauth2TokenUtilsService the oauth2 token server
* @param taskSaveService the task save service
* @param taskConfigurationProperties task configuration properties.
*/
@Deprecated
public DefaultTaskExecutionService(
PropertyResolver propertyResolver,
LauncherRepository launcherRepository,
AuditRecordService auditRecordService,
TaskRepository taskRepository,
TaskExecutionInfoService taskExecutionInfoService,
TaskDeploymentRepository taskDeploymentRepository,
TaskDefinitionRepository taskDefinitionRepository,
TaskExecutionCreationService taskExecutionRepositoryService,
TaskAppDeploymentRequestCreator taskAppDeploymentRequestCreator,
DataflowTaskExplorer taskExplorer,
DataflowTaskExecutionDao dataflowTaskExecutionDao,
DataflowTaskExecutionMetadataDao dataflowTaskExecutionMetadataDao,
DataflowTaskExecutionQueryDao dataflowTaskExecutionQueryDao,
OAuth2TokenUtilsService oauth2TokenUtilsService,
TaskSaveService taskSaveService,
TaskConfigurationProperties taskConfigurationProperties
) {
this(propertyResolver,
launcherRepository,
auditRecordService,
taskRepository,
taskExecutionInfoService,
taskDeploymentRepository,
taskDefinitionRepository,
taskExecutionRepositoryService,
taskAppDeploymentRequestCreator,
taskExplorer,
dataflowTaskExecutionDao,
dataflowTaskExecutionMetadataDao,
dataflowTaskExecutionQueryDao,
oauth2TokenUtilsService,
taskSaveService,
taskConfigurationProperties,
null);
}

/**
* Initializes the {@link DefaultTaskExecutionService}.
*
Expand Down
1 change: 1 addition & 0 deletions whats-new.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ VersionInfoProperties versionInfoProperties, SecurityStateBean securityStateBean
* The following deprecated `Converters` have been removed from SCDF: `AbstractDateTimeConverter`, `DateToStringConverter`, and `StringToDateConverter`. Use the converters provided by Spring Batch.
* `findByTaskNameContainsAndDslTextContains` deprecated method has been removed from `TaskDefinitionRepository`.
* `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck)` has been replaced by `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck, ReadableDuration timeout)`.
* Removed the `DefaultTaskExecutionService` constructor that does not take the `composedTaskRunnerConfigurationProperties` parameter. Use the constructor that offers the `composedTaskRunnerConfigurationProperties` parameter.

=== Breaking Changes
Announce deprecated changes here
Expand Down
Loading