Wrote WebClientHttpRoutingFilterTests. Relates to GH-73 #3334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran a coverage tool and noticed that one of the key
GlobalFiler
s,WebClientHttpRoutingFilter
, has a coverage of zero (at least, excluding integration tests). I bumped it up to 100%Also wrote a missing Javadoc
Important note. I want you to delay the merge until we figure out how to assert on
ClientResponse
's body. The last test,filter_ifNotRouted_ifSchemeHttps_receivedResponseStoredAsAttribute()
, was supposed to have this assertion as wellHowever, the body mono completes immediately so the assertion fails. I tried to pinpoint it on my own for a while, but then remembered that I no longer work on some pet project of mine and can continue solving that puzzle together with the Spring Cloud community. Maybe, it's not a puzzle at all