Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: X-Forwarded-Prefix not working when using MVC #3443

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

fix: X-Forwarded-Prefix not working when using MVC #3443

wants to merge 15 commits into from

Commits on Sep 28, 2024

  1. Add support for saving original request URL to request attributes

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    39c6237 View commit details
    Browse the repository at this point in the history

  2. save original request URL and updated request URL following prefix strip

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c33aeea View commit details
    Browse the repository at this point in the history

  3. use original request URL and updated request URL to calculate X-Forwa… 

    …rded-Prefix header. Also removed unused variable.
    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2e4552d View commit details
    Browse the repository at this point in the history

  4. Add support to HttpbinUriResolver for preserving the path of the reso… 

    …lved URL. This particular filter used in testing is currently throwing away the whole URL and building a new one, and it interferes with tests. This change allows the filter to be less destructive and do the bare minimum to ensure that requests are forwarded to HTTP Bin by changing only the hostname, port and scheme, but nothing else
    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    279af98 View commit details
    Browse the repository at this point in the history

  5. First stab at getting some integration tests running to verify that t… 

    …he X-Forwarded-Prefix header is added and what we expect.
    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    bad0448 View commit details
    Browse the repository at this point in the history

  6. remove commented out tests and ensure that we preserve the path when … 

    …testing strip prefix filter
    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    713e57c View commit details
    Browse the repository at this point in the history

  7. remove failing deploy docs job temporarily

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    5bd5c61 View commit details
    Browse the repository at this point in the history

  8. add master to list of target branches for running Maven build

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    d2b8c6b View commit details
    Browse the repository at this point in the history

  9. move position of http bin uri resolver filter back to original position

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2b2f1d5 View commit details
    Browse the repository at this point in the history

  10. move strip httpbin uri resolver filter back to later position

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c682aa5 View commit details
    Browse the repository at this point in the history

  11. re-order position of httpbin uri resolver filter in setup for test

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    fbe943c View commit details
    Browse the repository at this point in the history

  12. re-add deploy-docs.yml

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9852de1 View commit details
    Browse the repository at this point in the history

  13. add some extra assertions

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    0747ad4 View commit details
    Browse the repository at this point in the history

  14. remove master from accept list of PR branches to run tests on

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    2f8a33a View commit details
    Browse the repository at this point in the history

  15. Remove duplicated assertion

    @jrhenderson1988
    jrhenderson1988 committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    9432657 View commit details
    Browse the repository at this point in the history