Support reading the body multiple times in ReadBodyRoutePredicateFactory #3548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the
ReadBodyRoutePredicateFactory
that it states "we do not try to read the request body multiple times." This seems to impact the logic of route matching. The reproducible route definitions are as follows(or see unit test):If one route is not matched, it should not affect the matching of other routes. Additionally, we have placed the mutable request in the
CACHED_SERVER_HTTP_REQUEST_DECORATOR_ATTR
attribute, and we can continue to use it to address this.