Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring preidicate consistency by remove 'Validated' and adding 'Notnull'. #3583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apollyon4
Copy link

I removed @Validated from all predicates because it wasn't working.
Added @NotNull to BeforeRoutePredicateFactory.Config similar to AfterRoutePredicateFactory.

And I added some tests to verify correct behavior before and after removing @Validated and adding @NotNull.

This is a PR for the #3478 issue.

@apollyon4
Copy link
Author

While working on the predicates, I thought that if there’s no intention to configure the PathRoutePredicateFactory, HostRoutePredicateFactory, and MethodRoutePredicateFactory in a meaningful way, there’s no real reason to include them. Therefore, I think a null check for them would be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants