Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to extend broker responses #363

Open
wants to merge 3 commits into
base: 4.1.x
Choose a base branch
from

Conversation

indvd00m
Copy link

In some cases we need to extend OSB specification and add extra fields to responses from service broker. For example it is not possible right now write something like this:

public class MyCreateServiceInstanceResponse extends CreateServiceInstanceResponse {

    private final String myCustomField2;

    ...
}

and after that use this reponse in ServiceInstanceService:

public class MyServiceInstanceService implements ServiceInstanceService {
...
    @Override
    public Mono<MyCreateServiceInstanceResponse> createServiceInstance(CreateServiceInstanceRequest request) {
...
}

Java compiler throw exception like this in that case:

java: my.package.MyServiceInstanceService is not abstract and does not override abstract method createServiceInstance(org.springframework.cloud.servicebroker.model.instance.CreateServiceInstanceRequest) in org.springframework.cloud.servicebroker.service.ServiceInstanceService

This changes are intended to allow this to be done.

@royclarkson
Copy link
Member

I started reviewing this, and at first glance, it will cause some challenges with regard to generic types in method parameters and return types. I'll see where I can get with it, but my preference is to avoid significantly disrupting the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants