Skip to content

Commit

Permalink
Make parentExecutionId available to BeforeTask methods
Browse files Browse the repository at this point in the history
  • Loading branch information
cppwfs committed Dec 18, 2023
1 parent a2dca50 commit 7cd9863
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ private TaskExecution getTaskExecutionCopy(TaskExecution taskExecution) {
return new TaskExecution(taskExecution.getExecutionId(), taskExecution.getExitCode(),
taskExecution.getTaskName(), startTime, endTime, taskExecution.getExitMessage(),
Collections.unmodifiableList(taskExecution.getArguments()), taskExecution.getErrorMessage(),
taskExecution.getExternalExecutionId());
taskExecution.getExternalExecutionId(), taskExecution.getParentExecutionId());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public TaskExecution createTaskExecution(String taskName, LocalDateTime startTim
long nextExecutionId = getNextExecutionId();

TaskExecution taskExecution = new TaskExecution(nextExecutionId, null, taskName, startTime, null, null,
arguments, null, externalExecutionId);
arguments, null, externalExecutionId, parentExecutionId);

final MapSqlParameterSource queryParameters = new MapSqlParameterSource()
.addValue("taskExecutionId", nextExecutionId, Types.BIGINT)
Expand Down

5 comments on commit 7cd9863

@Yusufyes123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which build we can get this fix

@cppwfs
Copy link
Collaborator Author

@cppwfs cppwfs commented on 7cd9863 Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is associated with issue: #938. And will be in release 3.1.1.

@Yusufyes123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the ETA for release?

@cppwfs
Copy link
Collaborator Author

@cppwfs cppwfs commented on 7cd9863 Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is currently scheduled for Feb 20, 2024 according to calendar.spring.io.

@Yusufyes123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In same piece of code while setting taskExecution.setExitCode(1) but still receiving exit code 0.

Please sign in to comment.