Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.adoc #147

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Update README.adoc #147

merged 5 commits into from
Dec 12, 2023

Conversation

GeorgePanaretos
Copy link
Contributor

Update the README.adoc file for the below cases:

  • To copy the command for Maven or Gradle to the terminal of the user's choice to run the application.
  • Adding the http:// due to as it is in the guide it can be run only in the classic Command Prompt someone will deal with an error if tries for example to paste the command in the Intellij terminal or Windows Power Shell.

Adding note for the use of Spring Initializr
@GeorgePanaretos
Copy link
Contributor Author

Additional note for the use of Spring Initializr in case the user selects the Spring 3.0

README.adoc Outdated
@@ -69,6 +69,8 @@ NOTE: If your IDE has the Spring Initializr integration, you can complete this p

NOTE: You can also fork the project from Github and open it in your IDE or other editor.

NOTE: For Spring 3.0 you need Java 17 or later, regardless using Spring Initializr or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our usual fix for this is to remove the Java version from the Actuator link rather than add a note. Then the default Java version in the Initializr is correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look more closely at the wording, I see that it should be:

NOTE: For Spring 3.0 you need Java 17 or later, regardless of whether you use Spring Initializr.

Sorry I didn't catch it the first time. I was focused on the Initializr link.

README.adoc Outdated
@@ -69,6 +69,8 @@ NOTE: If your IDE has the Spring Initializr integration, you can complete this p

NOTE: You can also fork the project from Github and open it in your IDE or other editor.

NOTE: For Spring 3.0 you need Java 17 or later, regardless using Spring Initializr or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look more closely at the wording, I see that it should be:

NOTE: For Spring 3.0 you need Java 17 or later, regardless of whether you use Spring Initializr.

Sorry I didn't catch it the first time. I was focused on the Initializr link.

@Buzzardo Buzzardo merged commit fde35c3 into spring-guides:main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants