Fixes #4 node.getContext() is not a function

packages/antora-xref-extension/lib/index.js

@@ -92,21 +92,35 @@ function register ({ config }) {
   }
 
   function processNode (src, node, lookup) {
-    const context = node.getContext()
-    if (context === 'paragraph' || context === 'admonition') {
-      const lines = node.lines
-      for (let i = 0; i < lines.length; i++) {
-        lines[i] = processLine(src, node, lines[i], lookup)
+    if (Array.isArray(node)) {
+      // e.g. dlist
+      for (let i = 0; i < node.length; i++) {
+        if (node[i] !== null) {
+          processNode(src, node[i], lookup)
+        }
+      }
+      return
+    }
+
+    try {
+      const context = node.getContext()
+      if (context === 'paragraph' || context === 'admonition') {
+        const lines = node.lines
+        for (let i = 0; i < lines.length; i++) {
+          lines[i] = processLine(src, node, lines[i], lookup)
+        }
+      } else if (context === 'table') {
+        const rows = node.getRows()
+        rows.getHead().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
+        rows.getBody().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
+        rows.getFoot().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
+      } else if (context === 'table_cell' || context === 'list_item') {
+        node.text = processLine(src, node, node.text, lookup)
       }
-    } else if (context === 'table') {
-      const rows = node.getRows()
-      rows.getHead().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
-      rows.getBody().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
-      rows.getFoot().forEach((row) => row.forEach((cell) => processNode(src, cell, lookup)))
-    } else if (context === 'table_cell' || context === 'list_item') {
-      node.text = processLine(src, node, node.text, lookup)
+      node.getBlocks().forEach((child) => processNode(src, child, lookup))
+    } catch (t) {
+      log(node, 'warn', 'Parse error when validating xrefs.')
     }
-    node.getBlocks().forEach((child) => processNode(src, child, lookup))
   }
 
   function processLine (src, block, line, lookup) {

packages/antora-xref-extension/test/xref-fragments-extension-test.js

@@ -664,6 +664,87 @@ describe('xref extension', () => {
       expect(loggerDestination.messages).to.be.empty()
     })
 
+    it('should allow reference in dlist items', () => {
+      const extensionConfig = {
+        logUnnecessaryLinkTextWarnings: false,
+      }
+      addFile(
+        'target.adoc',
+        heredoc`
+      = Target
+
+      [[frag]]
+      == Fragment
+      The Fragment
+      `
+      )
+      addFile(
+        'xref.adoc',
+        heredoc`
+      = Dlist
+
+      Simple::
+
+      Simple1::
+      xref:target.adoc#frag[Existing]
+
+      Simple2:: xref:target.adoc#frag[Existing]
+
+      xref:target.adoc#frag[Existing]:: Also works
+
+      // These do not work, yet :(
+      // Numbered::
+      //  . xref:target.adoc#frag[Existing]
+
+      // 
+      // Outer::
+      //   Inner:::
+      //     xref:target.adoc#frag[Existing]
+      `
+      )
+      run(extensionConfig)
+      // console.log(loggerDestination.messages)
+      const page = contentCatalog.getPages((candidate) => candidate.path === '/xref.adoc')[0]
+      expect(loggerDestination.messages).to.be.empty()
+    })
+
+    it('should log warnings for dangling references from dlist items', () => {
+      const extensionConfig = {
+        logUnnecessaryLinkTextWarnings: false,
+      }
+      addFile(
+        'target.adoc',
+        heredoc`
+      = Target
+
+      [[frag]]
+      == Fragment
+      The Fragment
+      `
+      )
+      addFile(
+        'xref.adoc',
+        heredoc`
+      = Dlist
+
+      Simple1::
+      xref:target.adoc#dangling1[Dangling]
+
+      Simple2:: xref:target.adoc#dangling2[Dangling]
+
+      xref:target.adoc#dangling3[Dangling]:: Also works
+      `
+      )
+      run(extensionConfig)
+      const page = contentCatalog.getPages((candidate) => candidate.path === '/xref.adoc')[0]
+      expect(
+        loggerDestination.messages.length == 3 &&
+        loggerDestination.messages.every(
+          (message) => message.includes('"level":"error"') && message.includes('target fragement of xref not found: target.adoc#dangling')
+        )
+      ).to.be.true()
+    })
+
     function addFile (filename, contents) {
       contents = Buffer.from(contents)
       const mediaType = 'text/asciidoc'