Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jacoco to 0.8.11 such that we can build with JDK 21 #128

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

simonis
Copy link
Contributor

@simonis simonis commented Dec 28, 2023

Notice that building with JDK 17 and running with JDK 21 (including virtual threads support) works just fine, as long as we don't use virtual threads in our application because the Spring framework is packaged as a multi-release jar file. We only need to build with JDK 21 if we want to use 21 features in our application.

The jacoco upgrade is needed because jacoco tries to instrument some of the JDK classes and the current version 0.8.8 doesn't understand the JDK 21 classs if we are building with JDK 21.

@arey arey merged commit 4085009 into spring-petclinic:master Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants