Skip to content

Commit

Permalink
fix(initPhpLogging): Moving fetch settings to before settings check.
Browse files Browse the repository at this point in the history
There is the bug that you cannot disable PhpLogging since the settings
property is not set until fetchSettings() is called. So I reordered.
  • Loading branch information
spenserhale committed May 22, 2019
1 parent c57e1f9 commit db947a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Plugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,13 @@ public static function buildIncludedErrno($cutoff)

public function initPhpLogging()
{
$this->fetchSettings();

// Return if logging is not enabled
if ( $this->settings['php_logging_enabled'] === 0 ) {
return;
}

$this->fetchSettings();

// installs global error and exception handlers
try {

Expand Down

0 comments on commit db947a1

Please sign in to comment.