Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #258 + a config fix #327

Draft
wants to merge 1 commit into
base: 1.21-fabric
Choose a base branch
from

Conversation

thimblebird
Copy link

@thimblebird thimblebird commented Sep 11, 2024

  • Adds ability to show/hide hunger/saturation in tooltips (closes [Suggestion] Config option to hide saturation tooltip #258)
  • Fixes showFoodValuesInTooltip not overwriting showFoodValuesInTooltipAlways
    • (if showFoodValuesInTooltip is set to false, showFoodValuesInTooltipAlways shouldn't do anything, right?)

Feels a bit bloated and I really just quickly threw something together here that works afaik.
Is there a more sane way to implement this? especially regarding the diff readability/complexity caused by indentations.

Adds ability to show/hide hunger/saturation in tooltips
Fixes "showFoodValuesInTooltip" not overwriting "showFoodValuesInTooltipAlways"
@thimblebird thimblebird changed the title Closes https://github.com/squeek502/AppleSkin/issues/258 + a config fix Closes #258 + a config fix Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant