feat: allow using the UUID to search for nodes #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louib
force-pushed
the
get_with_uuid
branch
2 times, most recently
from
96afaae
to
b6e0b4b
Compare
varjolintu
approved these changes
Oct 29, 2023
sseemayer
approved these changes
Oct 30, 2023
|
@sseemayer @varjolintu I gave this one another shot and managed to have a static interface for both functions. Please have another look 👀 |
varjolintu
reviewed
Nov 4, 2023
varjolintu
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a few internal abstractions to make it easier to work with complex node paths. Using the UUID instead of the title or name is sometimes desirable because nothing guarantees that the entry titles or group names are unique. I also added a few
getandget_muttests to make sure there was no regression. The new types and functions are not public since I don't think they are stable just yet.This is a prerequisite to #155