Skip to content

Correct custom variable type attributes - #155

Merged
sshaw merged 1 commit into
sshaw:masterfrom
syohex:fix-custom-value-types
Jul 23, 2026
Merged

Correct custom variable type attributes#155
sshaw merged 1 commit into
sshaw:masterfrom
syohex:fix-custom-value-types

Conversation

@syohex

@syohex syohex commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

repeat type should be used for them because those values are variable length string list. While list type is used for fixed length list.

This also fixes byte-compile warnings

git-link.el:320:10: Warning: in defcustom for
    ‘git-link-extensions-rendered-plain’: ‘list’ without arguments
git-link.el:329:10: Warning: in defcustom for
    ‘git-link-extensions-rendered-via-bitbucket-annotate’: ‘list’ without arguments

Reference

`repeat` type should be used for them because those values are variable length
string list. While `list` type is used for fixed length list.

This also fixes byte-compile warnings
@sshaw

sshaw commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Thanks for the PR.

What Emacs version do you see these warnings on?

@syohex

syohex commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

What Emacs version do you see these warnings on?

Development version.

$ emacs --version
GNU Emacs 32.0.50
Development version b31954283556 on master branch; build date 2026-07-06.

@sshaw

sshaw commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Great, thanks!

@sshaw
sshaw merged commit ca01d01 into sshaw:master Jul 23, 2026
9 checks passed
@syohex
syohex deleted the fix-custom-value-types branch July 23, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants