Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batched tests #73

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add batched tests #73

merged 1 commit into from
Jun 25, 2024

Conversation

kylebarron
Copy link
Collaborator

@kylebarron kylebarron commented Jun 25, 2024

Add tests that read JSON as multiple chunks, instead of a single chunk. Happily no tests failed (though matching Arrow data can be finicky, and here it's more stable to do the match assertions on the JSON representation)

Ref #69 (comment)

Copy link
Collaborator

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TomAugspurger TomAugspurger merged commit fd51c9c into main Jun 25, 2024
1 check passed
@TomAugspurger TomAugspurger deleted the kyle/batched-tests branch June 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants