Skip to content

test: pin pam_unix_session_closed parser coverage telemetry - #113

Merged
stacknil merged 1 commit into
stacknil:mainfrom
VedantMadane:fix/issue-83-pam-session-closed
Aug 24, 2026
Merged

test: pin pam_unix_session_closed parser coverage telemetry#113
stacknil merged 1 commit into
stacknil:mainfrom
VedantMadane:fix/issue-83-pam-session-closed

Conversation

@VedantMadane

Copy link
Copy Markdown
Contributor

Summary

Review trace for #83: the first pam_unix(sshd:session) session-close sample in the mixed auth corpus.

Fixture line under review

assets/mixed_auth_corpus.log line 11:
ext Mar 12 08:00:41 ubuntu-auth-01 pam_unix(sshd:session): session closed for user user001

Confirmation

Already matches assets/mixed_auth_parser_coverage.json:

  • category: unsupported_pam_variant
  • reason: unrecognized auth pattern: pam_unix_session_closed
  • no parsed event; no detector findings

No fixture correction needed. This PR adds an explicit regression pin and a short ROADMAP note so the contract stays visible.

Test plan

  • test_mixed_auth_first_pam_unix_session_closed_is_unsupported_telemetry (manual g++ build of test_parser)

Fixes #83

Confirm assets/mixed_auth_corpus.log line 11
(pam_unix(sshd:session): session closed for user user001) matches
mixed_auth_parser_coverage.json as unsupported_pam_variant /
unrecognized auth pattern: pam_unix_session_closed, with no parsed
event and no detector finding.

Fixes stacknil#83

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>

@stacknil stacknil left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final maintainer review after CI:

  • Design decision: keep the first checked-in pam_unix(sshd:session) close sample as parser coverage telemetry and pin its exact corpus-line-to-artifact mapping; it must not become an Event or detector finding.
  • Main risk: the regression intentionally couples this assertion to corpus line 11, so future fixture reordering must update the pin together with the committed coverage artifact.
  • Compatibility impact: none for the parser, detector, CLI, report schemas, fixtures, or runtime dependencies; this is test and roadmap coverage only.
  • Rollback path: revert the merge commit to remove the explicit pin without changing current runtime behavior.

Validation: local MSVC Release build with warnings-as-errors, targeted parser CTest 1/1, full CTest 6/6, git diff --check, changed-line privacy/secret scan, plus all GitHub CI, fuzz, CodeQL, and Repo Sentinel checks passed.

@stacknil
stacknil merged commit 2b53219 into stacknil:main Aug 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace pam_unix_session_closed through parser coverage

2 participants