test: pin pam_unix_session_closed parser coverage telemetry - #113
Merged
stacknil merged 1 commit intoAug 24, 2026
Merged
Conversation
Confirm assets/mixed_auth_corpus.log line 11 (pam_unix(sshd:session): session closed for user user001) matches mixed_auth_parser_coverage.json as unsupported_pam_variant / unrecognized auth pattern: pam_unix_session_closed, with no parsed event and no detector finding. Fixes stacknil#83 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
stacknil
approved these changes
Aug 24, 2026
stacknil
left a comment
Owner
There was a problem hiding this comment.
Final maintainer review after CI:
- Design decision: keep the first checked-in
pam_unix(sshd:session)close sample as parser coverage telemetry and pin its exact corpus-line-to-artifact mapping; it must not become an Event or detector finding. - Main risk: the regression intentionally couples this assertion to corpus line 11, so future fixture reordering must update the pin together with the committed coverage artifact.
- Compatibility impact: none for the parser, detector, CLI, report schemas, fixtures, or runtime dependencies; this is test and roadmap coverage only.
- Rollback path: revert the merge commit to remove the explicit pin without changing current runtime behavior.
Validation: local MSVC Release build with warnings-as-errors, targeted parser CTest 1/1, full CTest 6/6, git diff --check, changed-line privacy/secret scan, plus all GitHub CI, fuzz, CodeQL, and Repo Sentinel checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review trace for #83: the first
pam_unix(sshd:session)session-close sample in the mixed auth corpus.Fixture line under review
assets/mixed_auth_corpus.logline 11:ext Mar 12 08:00:41 ubuntu-auth-01 pam_unix(sshd:session): session closed for user user001Confirmation
Already matches
assets/mixed_auth_parser_coverage.json:category:unsupported_pam_variantreason:unrecognized auth pattern: pam_unix_session_closedNo fixture correction needed. This PR adds an explicit regression pin and a short ROADMAP note so the contract stays visible.
Test plan
test_mixed_auth_first_pam_unix_session_closed_is_unsupported_telemetry(manual g++ build oftest_parser)Fixes #83