Skip to content

Flush JSON writer at end of records - #3417

Closed
WardBrian wants to merge 1 commit into
developfrom
json-writer-flush-end-record
Closed

Flush JSON writer at end of records#3417
WardBrian wants to merge 1 commit into
developfrom
json-writer-flush-end-record

Conversation

@WardBrian

@WardBrian WardBrian commented Aug 28, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Should close stan-dev/cmdstan#1349 (@jgabry @bgoodri I'd appreciate you trying it out!)

Intended Effect

Write to file at the end of JSON records (in particular, also at the end of the file, which is a record)

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@jgabry

jgabry commented Aug 28, 2026

Copy link
Copy Markdown
Member

Oops, I just submitted a PR for this too! I hadn't seen this one

@WardBrian WardBrian closed this Aug 28, 2026
@WardBrian
WardBrian deleted the json-writer-flush-end-record branch August 28, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving metric with large models produces truncated JSON files

2 participants