Skip to content

Flush JSON after top level finishes #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgabry merged 3 commits into from
Aug 28, 2026
+2 −1
Merged

Flush JSON after top level finishes #3418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc9fcaa
json_writer.hpp: flush when the top-level closes
jgabry Aug 28, 2026
75d9cd0
tests for json flushing
jgabry Aug 28, 2026
52dd7b3
Revert "tests for json flushing"
jgabry Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/stan/callbacks/json_writer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace callbacks {
* The writer doesn't try to validate the object's internal structure
* or object completeness, only syntactic correctness.
*
* @tparam Stream A type with with a valid `operator<<(std::string)`
* @tparam Stream A type with a valid `operator<<(std::string)` and `flush()`
* @tparam Deleter A class with a valid `operator()` method for deleting the
* output stream
*/
Expand Down Expand Up @@ -227,6 +227,7 @@ class json_writer final : public structured_writer {
record_element_needs_comma_ = true;
} else {
*output_ << "\n";
output_->flush();
}
}

Expand Down
Loading