Fix to compilation and warnings on ubuntu 18.04 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by functions in gm_error.cc using 'int errno' as function parameter, while the header defines the parameter as 'int errnumber'. This is a problem, as errno.h is included which defines errno to be: #define errno (*__errno_location ()) which effectively changes the function parameter in the gm_error.cc file to take a function pointer as the first argument and therefore the other code doesn't find the symbols. Signed-off-by: Reto Achermann <rachermann@vmware.com>
Signed-off-by: Reto Achermann <rachermann@vmware.com>
Signed-off-by: Reto Achermann <rachermann@vmware.com>
Signed-off-by: Reto Achermann <rachermann@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5965bb0: hash define of
errnoin the headererrno.hcauses linking errors.ef9c2a8: squash compiler warning
be214fc: adding missing
;that prevented the grammar to be compiled.