Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remedy type declaration roll-up issues #683

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: remedy type declaration roll-up issues #683

merged 1 commit into from
Jul 17, 2023

Conversation

penovicp
Copy link
Collaborator

Motivation and Resolution

Resolve #679

@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited
Loading

✅ Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 8668212
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/64af7a9fc77a680008b9da66

@penovicp penovicp marked this pull request as ready for review July 13, 2023 04:28
@penovicp penovicp changed the base branch from develop to next-version July 13, 2023 07:01
ivpavici
ivpavici approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@ivpavici ivpavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@penovicp penovicp merged commit 48625f4 into next-version Jul 17, 2023
@penovicp penovicp deleted the fix/dts branch July 17, 2023 12:15
@github-actions
Copy link

🎉 This PR is included in version 5.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivpavici ivpavici ivpavici approved these changes

@tabaktoni tabaktoni Awaiting requested review from tabaktoni

Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken TypeScript declarations since 5.4.0
2 participants
@penovicp @ivpavici