-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: abiwan integration for TS validation based on ABI #696
Feat: abiwan integration for TS validation based on ABI #696
Conversation
✅ Deploy Preview for starknetjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Related to keep-starknet-strange/abi-wan-kanabi#30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Couple of small issues to deal with:
- It would be nice to export tAbi from mocks/TAbi.ts and import into tests.
- I think we can skip of execution of all test in _typed.test as we just need to check typing system and not execution and runtime (mark all tests with xtest and skip beforeAll, or create a general skip rule)
…p TS validation tests
Closes #140 |
🎉 This PR is included in version 5.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation and Resolution
Usage related changes
TypedContract<Abi>
instead ofContract
by callingtyped(abi)
function on their contractsDevelopment related changes
No changes
Checklist: