Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add units to FEE_ESTIMATE #175

Merged
merged 2 commits into from
Nov 27, 2023
Merged

add units to FEE_ESTIMATE #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab96462
add unit to FEE_ESTIMATE
ArielElp Nov 27, 2023
01ba2e0
update estimateFee description
ArielElp Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions api/starknet_api_openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@
{
"name": "starknet_estimateFee",
"summary": "estimate the fee for of StarkNet transactions",
"description": "Estimates the resources required by a given sequence of transactions when applied on a given state. If one of the transaction reverts, a TRANSACTION_EXECUTION_ERROR is returned.",
"description": "Estimates the resources required by a given sequence of transactions when applied on a given state. If one of the transactions reverts or fails due to any reason (e.g. validation failure or an internal error), a TRANSACTION_EXECUTION_ERROR is returned. For v0-2 transactions the estimate is given in wei, and for v3 transactions it is given in fri.",
"params": [
{
"name": "request",
Expand Down Expand Up @@ -3638,6 +3638,14 @@
],
"description": "Flags that indicate how to simulate a given transaction. By default, the sequencer behavior is replicated locally"
},
"PRICE_UNIT": {
"title": "price unit",
"type": "string",
"enum": [
"WEI",
"FRI"
]
},
"FEE_ESTIMATE": {
"title": "Fee estimation",
"type": "object",
Expand All @@ -3656,12 +3664,18 @@
"title": "Overall fee",
"description": "The estimated fee for the transaction (in gwei or fri, depending on the tx version), product of gas_consumed and gas_price",
"$ref": "#/components/schemas/FELT"
},
"unit": {
"title": "Fee unit",
"description": "units in which the fee is given",
"$ref": "#/components/schemas/PRICE_UNIT"
}
},
"required": [
"gas_consumed",
"gas_price",
"overall_fee"
"overall_fee",
"unit"
]
},
"FEE_PAYMENT": {
Expand All @@ -3675,12 +3689,9 @@
"$ref": "#/components/schemas/FELT"
},
"unit": {
"title": "fee unit",
"type": "string",
"enum": [
"WEI",
"FRI"
]
"title": "Fee unit",
"description": "units in which the fee is given",
"$ref": "#/components/schemas/PRICE_UNIT"
}
},
"required": [
Expand Down