Fix umask comments #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,11 +63,11 @@ | |||
| # | |||
| # So: if the group name is the same as the username OR the user id is not | |||
| # greater than 99 (i.e. not root or a privileged user), then we are on a | |||
| # local machine (check for yourself), so we set umask 002. | |||
| # local machine (check for yourself), so we set umask 022. | |||
| # | |||
| # Conversely, if the default group name is *different* from the username | |||
There was a problem hiding this comment.
Should be “if the default group name is the same as the username”
roman-spiridonov
referenced
this pull request
in roman-spiridonov/devops
Mar 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think the umask comments are switched up, umask masks bits rather than sets them. Note however that the actual shell code sets the umask correctly.