Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using mkdocs to serve docs from our markdown files #62

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

haraldsvik
Copy link
Contributor

Docs!

The docs are available through github pages here: https://statisticsnorway.github.io/microdata-tools/

I'm using mkdocs material theme with some custom css (Just 2 color changes so no worries backend ppl! ) to get closer to the microdata style & theme.

  --md-primary-fg-color: #104050;
  --md-accent-fg-color: #e94f35;

There were some markdown which didn't render correct in the mkdocs (mostly due to extra space or lack of space). So keep an eye out for things I've missed.

The actual pages are rendered from a separate branch which only contains the built docs. The docs should

NB

It uses https://github.com/peaceiris/actions-gh-pages/tree/v3/ a third-party to deploy to gh-pages. ( It seems like a recommended approach) And should be fine for our open-source docs.

Here are some screenshots:

Screenshot 2024-09-24 at 12 49 40
Screenshot 2024-09-24 at 12 50 09

@haraldsvik haraldsvik requested a review from a team as a code owner September 24, 2024 11:18
Copy link
Contributor

@DanielElisenberg DanielElisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and simple to navigate files 💯 Added suggestion for simpler deploy ✨

run: mkdocs build --clean

- name: Deploy to GitHub Pages
uses: peaceiris/actions-gh-pages@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion!

@@ -0,0 +1,53 @@
site_name: Microdata-tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

sonarcloud bot commented Sep 25, 2024

@haraldsvik haraldsvik requested a review from a team September 25, 2024 08:53
Copy link
Contributor

@DanielElisenberg DanielElisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try 💯

@haraldsvik haraldsvik merged commit fa82da3 into main Sep 25, 2024
8 checks passed
@haraldsvik haraldsvik deleted the mkdocs branch September 25, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants