Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving action permissions #63

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Giving action permissions #63

merged 4 commits into from
Sep 25, 2024

Conversation

haraldsvik
Copy link
Contributor

giving action permission to deploy by adding github token and info.

Worked!

@haraldsvik haraldsvik requested a review from a team as a code owner September 25, 2024 10:52
- name: Configure Git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't they have to do that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, maybe they have different repo settings?

Saw multiple places saying you needed to add credentials
from the material theme:
https://squidfunk.github.io/mkdocs-material/publishing-your-site/
it was one of the things which the previous deploy action said they handled..

@@ -10,8 +10,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you remove this like you have done I think that should be enough? (Seems like the default is true) Then the git credentials from the checkout are persisted 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can give it another try

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it worked 💯

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Contributor

@DanielElisenberg DanielElisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@haraldsvik haraldsvik merged commit 6c54b24 into main Sep 25, 2024
8 checks passed
@haraldsvik haraldsvik deleted the docs-action branch September 25, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants