Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Pydantic models #17

Merged
merged 187 commits into from
Nov 16, 2023
Merged

Generate Pydantic models #17

merged 187 commits into from
Nov 16, 2023

Conversation

mmwinther
Copy link
Member

@mmwinther mmwinther commented Nov 14, 2023

  • Add workflow to generate Pydantic models using datamodel-codegen
  • Add a description to the percentage_complete field to test generation.

There are many commits on this branch because the workflow triggered itself for a period of time, this is now fixed.

Internal ref: DPSTAT-694

@mmwinther mmwinther requested a review from a team November 16, 2023 11:44
Andilun
Andilun previously approved these changes Nov 16, 2023
Copy link

@Andilun Andilun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, nice work!

@mmwinther mmwinther dismissed Andilun’s stale review November 16, 2023 11:58

The merge-base changed after approval.

Andilun
Andilun previously approved these changes Nov 16, 2023
@mmwinther mmwinther dismissed Andilun’s stale review November 16, 2023 12:21

The merge-base changed after approval.

@mmwinther mmwinther closed this Nov 16, 2023
@mmwinther mmwinther reopened this Nov 16, 2023
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmwinther mmwinther merged commit 61446af into main Nov 16, 2023
2 checks passed
@mmwinther mmwinther deleted the generate-python branch November 16, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants