Skip to content

feat: add C implementation for stats/base/ndarray/snanmaxabs - #14477

Open
AryanSharma48 wants to merge 5 commits into
stdlib-js:developfrom
AryanSharma48:feats-stats-base-ndarray-snanmaxabs-c
Open

feat: add C implementation for stats/base/ndarray/snanmaxabs#14477
AryanSharma48 wants to merge 5 commits into
stdlib-js:developfrom
AryanSharma48:feats-stats-base-ndarray-snanmaxabs-c

Conversation

@AryanSharma48

Copy link
Copy Markdown
Contributor

Part of #14034.

Description

What is the purpose of this pull request?

This pull request:

  • adds the native C implementation for @stdlib/stats/base/ndarray/snanmaxabs.
  • adds the Node-API boilerplate and tryRequire dispatcher to safely fall back to the pure JS implementation.
  • includes the required C benchmarks, native JS benchmarks, and C examples mirroring the canonical structure.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution.

I utilized AI assistance solely to help scaffold the repetitive test and benchmark boilerplate based on the snanmin reference package. The C implementation and native bindings were handled manually.


@stdlib-js/reviewers

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 21, 2026
@stdlib-bot

stdlib-bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/snanmaxabs $\\color{red}171/176$
$\\color{green}+0.00\\%$
$\\color{red}4/5$
$\\color{green}+0.00\\%$
$\\color{red}1/2$
$\\color{green}+0.00\\%$
$\\color{red}171/176$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@AryanSharma48 AryanSharma48 changed the title feat: add C implementation for stats/base/ndarray/snanmaxabs [WIP] feat: add C implementation for stats/base/ndarray/snanmaxabs Aug 21, 2026
@AryanSharma48
AryanSharma48 marked this pull request as ready for review August 21, 2026 12:17
@AryanSharma48
AryanSharma48 requested a review from a team August 21, 2026 12:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants