build: add no-useless-format ESLint rule - #14519
Open
Planeshifter wants to merge 1 commit into
Open
Conversation
7 tasks
Planeshifter
force-pushed
the
philipp/no-useless-format-lint-rule
branch
from
August 22, 2026 06:20
1608ede to
5ed2eaa
Compare
Planeshifter
commented
Aug 22, 2026
| @@ -1 +1 @@ | |||
| /* eslint-disable stdlib/jsdoc-doctest-marker, stdlib/jsdoc-example-require-spacing, stdlib/jsdoc-no-tabs */ | |||
Member
Author
There was a problem hiding this comment.
Automatically removed by our ESLint autofix because these are not needed anymore here.
Planeshifter
force-pushed
the
philipp/no-useless-format-lint-rule
branch
3 times, most recently
from
August 22, 2026 06:36
44723ab to
6cd4524
Compare
Adds a custom ESLint rule which disallows calls to the format function
exported by `@stdlib/string/format` when the format string does not
contain any placeholders. Such calls are unnecessary, as the format
function simply returns the input string unchanged. The rule is
auto-fixable: the fixer replaces the format call with the string
literal argument.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Planeshifter
force-pushed
the
philipp/no-useless-format-lint-rule
branch
from
August 22, 2026 06:37
6cd4524 to
4038496
Compare
Planeshifter
changed the title
no-useless-format ESLint ruleno-useless-format ESLint rule
Planeshifter
marked this pull request as ready for review
August 22, 2026 06:39
Member
|
To ensure consistent naming (e.g., see https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/_tools/eslint/rules/no-unnecessary-nested-functions), can we rename this rule to |
kgryte
added
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#1214.
Description
This pull request:
stdlib/no-useless-format) which disallows calls to the format function exported by@stdlib/string/formatwhen the format string does not contain any placeholders (i.e., no string interpolation is performed).Implementation notes:
@stdlib/string/base/format-tokenizeto tokenize the format string. If every token is a plain string (no placeholder objects), the format call is flagged as unnecessary.%%) produce plain string tokens, soformat( '100%%' )is correctly flagged.#.call/#.applyand calls where the first argument is not a string literal.Running the rule over the entire repository found 37 files with violations. Fixes are submitted separately in a companion PR.
Related Issues
This pull request has the following related issues:
format-argsESLint rule #14518 (format-argsrule)Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code under my direction and instructions.
@stdlib-js/reviewers
🤖 Generated with Claude Code