Make numbered list regex more strict #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great contribution, thank you! Would you mind adding a unit test to prevent regressions in future releases? |
|
Sure thing! I've added those tests; maybe more than necessary, but wanted to check all the combinations of whitespace and non-numerals. Not like these take a long time to run, but let me know if it's not what you expected. Tests fail on 1.8.1 branch and pass with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexps used for identifying numbered lists were not strict enough, causing non-list lines to be identified as lists.
More information is on nextcloud/notes-android#1848 - this PR fixes the described bug.