add socket tier 1 reachability analysis - #2634
Open
kanwalpreetd wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a scheduled GitHub Actions workflow to run Socket’s “full application reachability” scan against the stellar-cli repo, with a log-based warning mechanism to distinguish Tier 1 reachability from Tier 2 fallback results.
Changes:
- Introduces a new scheduled + manually dispatchable “Socket reachability scan” workflow.
- Installs Node + Socket CLI and runs
socket scan create --reach, emitting a GitHub Actions warning if Tier 2 fallback markers appear in the output. - Sets an environment opt-in to run JS-based actions on Node 24.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80f2814001
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Drop the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env block: every action here already declares `using: node24`, and runners have defaulted to Node 24 since 2026-06-16 (Node 20 is removed 2026-09-16) - Remove the unused Corepack step; corepack only shims yarn/pnpm, and this repo uses neither - Replace dtolnay/rust-toolchain with `rustup update`, matching this repo's other workflows and dropping a third-party action from a security workflow. This also fixes a real mismatch: the pinned 1.86.0 was below this repo's declared MSRV of 1.93.0 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| - run: rustup update |
| node-version: "24.18.0" | ||
|
|
||
| - name: Install Socket CLI | ||
| run: npm install -g socket |
Comment on lines
+69
to
+70
| if [ $rc -eq 0 ] && grep -qE "Reachability falls back to Tier 2|fallback to the results from the pre-computed|Reachability falls back to precomputed" /tmp/scan.log; then | ||
| echo "::warning::Socket scan completed with Tier 2 fallbacks - some vulnerabilities used precomputed reachability instead of full Tier 1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5689311233/Socket+Tier+1+Reachability+Analysis