Release 1.7.0 -- no longer use Fiber - reverts Fiber changes in release 1.6.0 #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96 and Fixes #98
Unless a Fiber is initialized with
Fiber.new(storage: nil)
then there is cross Fiber pollution of the RequestStore if the RequestStore is initialized or used in any parent Fiber.Notes
1.6.0 added a method
RequestStore.scope
-- I was tempted to keep the method in 1.7.0 but decided to remove it for two reasons even though it is a breaking change.RequestStore.scope