Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev to main #32

Merged
merged 40 commits into from
Mar 22, 2024
Merged

Merge dev to main #32

merged 40 commits into from
Mar 22, 2024

Conversation

RobFirth
Copy link
Contributor

Description

Merge dev to main

Details

Changes include:

  • ruff
  • mypy >1 version
  • regex v2022

print python version
update mypy and package version
…-use-of-langchain-openai

27 update to regex 2022118 to enable use of langchain openai
…tion-due-to-deprecation-warning

remove epylint dependency and use updated API
Copy link
Contributor Author

@RobFirth RobFirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm happy. There are a few things I think we should make note of or address before we go ahead, but I think most of them are minor.

  • agree re: pylint
  • versions of python and poetry - agree which we should use

.github/workflows/lint.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
Alex-JG3 and others added 8 commits March 8, 2024 14:23
Co-authored-by: Robert Firth <robert.firth@stfc.ac.uk>
Pylint requires a version of python in the range >=3.8 and <4.0 so the
python range also has to be made more strict.
Co-authored-by: Robert Firth <robert.firth@stfc.ac.uk>
@Alex-JG3
Copy link
Contributor

versions of python and poetry - agree which we should use

In the CI/CD we have switched 1.8.2 which is much more recent version of poetry. I think the only thing that could cause backwards compatibility issues is (in the pyproject.toml) switching from the old group syntax,

[tool.poetry.dev-dependencies]

to the new group syntax

[tool.poetry.group.dev.dependencies]

According to the documentation, the new syntax was introduced in 1.2. This is an old enough version that I think we can expect users to upgrade to at least 1.2.

For the python version, I think we should stick with 3.9 as the default for the time being. When we upgrade to 3.10 on repo-templates perhaps we can think about testing both 3.9 and 3.10. But, I think that is a job for another PR.

@RobFirth
Copy link
Contributor Author

I've used git-changelog previously here to have good control over the inclusions in the CHANGELOG.md for repo-templates

@Alex-JG3 Alex-JG3 merged commit 6a1336f into main Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants