-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev to main #32
Conversation
…hrows-exeption-due-to-deprecation-warning
print python version
update mypy and package version
…-use-of-langchain-openai 27 update to regex 2022118 to enable use of langchain openai
bump version to 0.3.6
…to-deprecation-warning
…tion-due-to-deprecation-warning remove epylint dependency and use updated API
update to v0.3.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm happy. There are a few things I think we should make note of or address before we go ahead, but I think most of them are minor.
- agree re: pylint
- versions of python and poetry - agree which we should use
Co-authored-by: Robert Firth <robert.firth@stfc.ac.uk>
Pylint requires a version of python in the range >=3.8 and <4.0 so the python range also has to be made more strict.
Co-authored-by: Robert Firth <robert.firth@stfc.ac.uk>
In the CI/CD we have switched 1.8.2 which is much more recent version of poetry. I think the only thing that could cause backwards compatibility issues is (in the pyproject.toml) switching from the old group syntax,
to the new group syntax
According to the documentation, the new syntax was introduced in 1.2. This is an old enough version that I think we can expect users to upgrade to at least 1.2. For the python version, I think we should stick with 3.9 as the default for the time being. When we upgrade to 3.10 on repo-templates perhaps we can think about testing both 3.9 and 3.10. But, I think that is a job for another PR. |
I've used |
Description
Merge dev to main
Details
Changes include: