ENH: add hv search action #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 98.08% 98.12% +0.03%
==========================================
Files 217 223 +6
Lines 8253 8408 +155
Branches 501 511 +10
==========================================
+ Hits 8095 8250 +155
Misses 137 137
Partials 21 21 ☔ View full report in Codecov by Sentry. |
gmatthews20
previously approved these changes
Sep 25, 2024
lizsalmon
requested changes
Sep 27, 2024
anish-mudaraddi
force-pushed
the
add-hv-search-action
branch
from
2bf5ce7
to
a7b90a3
Compare
gmatthews20
previously approved these changes
Oct 4, 2024
lizsalmon
requested changes
Oct 4, 2024
Allows users to query for hypervisors based on a property
copy-paste error
pass group-by as a string instead - as we cannot pass null via enum and therefore can't keep this optional
Co-authored-by: lizsalmon <144809798+lizsalmon@users.noreply.github.com>
anish-mudaraddi
force-pushed
the
add-hv-search-action
branch
from
fea9b45
to
7548372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add hv.search.by.property action and fix other search actions so that they work without needing to specify group-by