WASM CI #445
WASM CI #445
Conversation
…ite correctly setting -DBOOST_ROOT.
…at least one pthread symbol at link time
…riable to fix compilation
…nel' which will execute with emrun
…o get things working
… former does not fully support exceptions
Yes. There's just one - see executor_test.cpp, introduced with #306. |
.github/workflows/stlab.yml
Outdated
| @@ -34,54 +34,98 @@ jobs: | |||
| - name: Install dependencies (macos) | |||
| if: ${{ startsWith(matrix.config.os, 'macos') }} | |||
| run: | | |||
| brew update | |||
| brew install boost | |||
| brew install ninja | |||
| shell: bash | |||
|
|
|||
| - name: Install dependencies (ubuntu) | |||
There was a problem hiding this comment.
Maybe call this "Install dependencies (Linux GCC/Clang)" and the new one "Install dependencies (Linux Webassembly)"? I'm going off the names in the matrix file. It'd be good if we could figure out something consistent.
There was a problem hiding this comment.
Yeah I also mulled this over and I'm craving consistency. I'll take another crack at it.
There was a problem hiding this comment.
Took a crack at it, not satisfied but it crossed my 80/20 threshold. Let me know what you think.
https://github.com/stlab/libraries/runs/7640371961?check_suite_focus=true
Co-authored-by: David Sankel <dsankel@adobe.com>
…STLab.cmake per code review
There was a problem hiding this comment.
I did a white-glove review. This code is top quality. I'm approving, but there are a couple (minor) remaining issues.
- I made a handful of comment rewording and formatting suggestions.
- The top-level PR comment references
cmake/ExperimentalEmscripten.cmakestill. I didn't notice any other issues, but it'd probably be good for you to give it a once-over. I assume this PR title+comment is going to be the squash&merge commit message.
Co-authored-by: David Sankel <dsankel@adobe.com>
Co-authored-by: David Sankel <dsankel@adobe.com>
This PR adds CI support for Webassembly. It resolves #404, #405, and part of #406.
Note: 406 still requires unit tests for the WASM
main_executorto be considered complete.This introduces a CMake toolchain file,
cmake/Platform/Emscripten-STLab.cmakewhich extends the Emscripten SDK's own toolchain, and enables some experimental features required by STLab tests to compile and run successfully. Those features are threading support and exception handling.Following our existing convention, the tests may be executed simply with
ctestfrom the build directory. A node runner is used.Note that Node 16.16.0 or newer is required for sufficient exception handling support. The new CMake toolchain will report an error if this requirement is not satisfied. To use an appropriate version, we must edit a configuration file
.emscriptenin the emsdk directory to point to the system installation of node (16.16.0 is installed for GH Actions).