Fix creation of temporary directory #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plntyk
pushed a commit
to plntyk/QComicBook
that referenced
this pull request
May 22, 2020
Since QComicBook switched to Qt5, it is posssible to use QTemporaryDir to create temporary directories: this solves few problems: - picking a unique random name - creating safely the directory (so far the temporary directory has been readable by anyone, not just the user, leaving a data leak) - cleanup is done automatically, in the same way, no matter what is the structure of the files there [v2] rebase on latest changes [v2] stolowski#27
Since QComicBook switched to Qt5, it is posssible to use QTemporaryDir to create temporary directories: this solves few problems: - picking a unique random name - creating safely the directory (so far the temporary directory has been readable by anyone, not just the user, leaving a data leak) - cleanup is done automatically, in the same way, no matter what is the structure of the files there Fixes: stolowski#39
pinotree
force-pushed
the
qtemporarydir
branch
from
9ff3f67
to
0792507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since QComicBook switched to Qt5, it is posssible to use
QTemporaryDirto create temporary directories: this solves few problems:Fixes: #39