Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use .mjs instead #116

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: use .mjs instead #116

merged 1 commit into from
Sep 17, 2024

Conversation

alvarosabu
Copy link
Contributor

Pull request type

Jira Link: INT-

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

How to test this PR

  • Run node dist/cli.mjs generate-migration
  • Remove type:module from the root package.json
  • Run node dist/cli.mjs run-migration

What is the new behavior?

  • Migration files should be now .mjs and should run without errors

Other information

@alvarosabu alvarosabu added p4-important [Priority] Violate documented behavior or significantly improve performance (priority) bugfix [PR] Fixes a bug labels Sep 13, 2024
@alvarosabu alvarosabu self-assigned this Sep 13, 2024
@alvarosabu alvarosabu linked an issue Sep 13, 2024 that may be closed by this pull request
run-migration is broken after ESM migration #95
Closed
Edo-San
Edo-San approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Edo-San Edo-San left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I thought there were more .js repetitions here and there but this should be enough!

@privetkuku privetkuku mentioned this pull request Sep 16, 2024
Closed
@alvarosabu alvarosabu merged commit ad5a50b into master Sep 17, 2024
1 check failed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.33.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@privetkuku
Copy link

privetkuku commented Sep 17, 2024 •
edited
Loading

@alvarosabu, hello!
I noticed that logs have still old extension names (https://github.com/storyblok/storyblok-cli/blob/master/src/cli.ts#L394). Can you also please update them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edo-San Edo-San Edo-San approved these changes

Assignees

@alvarosabu alvarosabu

Labels
bugfix [PR] Fixes a bug p4-important [Priority] Violate documented behavior or significantly improve performance (priority) released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run-migration is broken after ESM migration
3 participants
@alvarosabu @privetkuku @Edo-San