Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preset being [{}] error #53

Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix preset being [{}] error #53

merged 3 commits into from
Aug 10, 2023

Conversation

MarkusWendorf
Copy link
Contributor

@MarkusWendorf MarkusWendorf commented Jun 18, 2023

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Other (please describe):

Fixes https://github.com/MarkusWendorf/storyblok-cli-bug

How to test this PR

The bug:

git clone https://github.com/MarkusWendorf/storyblok-cli-bug
npm i
// Change script to use your own spaceId (and login)
npm run push-components

You should see an error, because the CLI is trying to update a preset with the value {} because the presets variable is set to [{}].

To test the fix

git clone https://github.com/MarkusWendorf/storyblok-cli
npm i
npm link

Go to the bug repo:

cd storyblok-cli-bug
npm link storyblok
npm run push-components

Push components should now work.

Copy link
Member

@ademarCardoso ademarCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @MarkusWendorf, please, take a look in my comment and then we can processe with the merge 💪🏼

@ademarCardoso ademarCardoso merged commit f348061 into storyblok:master Aug 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.25.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants