bugfix(int-512): fix mask in sbTextField and SbDatepicker #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandacanto
requested review from
thiagosaife,
lisilinhart and
carlosericciardi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The date is applied only if using "enter", it is good to persist the date changed on the focus lost too. |
ademarCardoso
approved these changes
Aug 30, 2022
carlosericciardi
approved these changes
Aug 30, 2022
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we had to remove the v-mask package, because the focus was getting lost, this issue is already mapped and there are 2 issues open in the v-mask package (probil/v-mask#59 and probil/v-mask#465), but as we can't wait for the fix I had to change the package to maska.
I recorded this video showing the problem happening:
Gravacao.de.Tela.2022-08-29.as.16.16.03.mov
Pull request type
Jira Link: INT-512
How to test this PR
Watch the video and check if the errors shown are no longer happening.