Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory requests and limits padding fix when requests = limits #692

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Sep 20, 2023

Fixes #691

Motivation

use 90% value of memory requests to the JVM when requests = limits

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet requested review from nlu90 and a team as code owners September 20, 2023 05:23
@freeznet freeznet self-assigned this Sep 20, 2023
@github-actions
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 20, 2023
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Sep 20, 2023
@github-actions
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the doc-required This pr needs a document label Sep 20, 2023
@jiangpengcheng jiangpengcheng merged commit da5a0c2 into master Oct 23, 2023
12 checks passed
@jiangpengcheng jiangpengcheng deleted the freeznet/memory-configs branch October 23, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document m/2023-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow memory requests to be equal as the memory limits
2 participants