Upgrade to go lint 1.61 (#514)

.github/workflows/pr_build_and_test.yaml

@@ -59,11 +59,10 @@ jobs:
         run: make build
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 #v3.3.1
+        uses: golangci/golangci-lint-action@v6.1.0
         with:
-          version: v1.55.2
+          version: v1.61.0
           args: --timeout=10m
-          skip-pkg-cache: true
 
       - name: Test
         run: make test

.golangci.yaml

@@ -125,6 +125,9 @@ linters-settings:
       - name: bare-return
         severity: warning
         disabled: false
+  gosec:
+    excludes:
+      - G115
 
 issues:
   fix: true

cmd/coordinator/cmd.go

@@ -143,7 +143,7 @@ func exec(*cobra.Command, []string) error {
 		return loadClusterConfig(v)
 	}
 
-	v.OnConfigChange(func(e fsnotify.Event) {
+	v.OnConfigChange(func(_ fsnotify.Event) {
 		conf.ClusterConfigChangeNotifications <- nil
 	})
 

common/security/tls.go

@@ -118,7 +118,7 @@ func (tls *TLSOption) MakeClientTLSConf() (*libtls.Config, error) {
 		tlsConf.RootCAs = certPool
 	}
 
-	tlsConf.GetClientCertificate = func(unused *libtls.CertificateRequestInfo) (cert *libtls.Certificate, err error) {
+	tlsConf.GetClientCertificate = func(_ *libtls.CertificateRequestInfo) (cert *libtls.Certificate, err error) {
 		c, err := libtls.LoadX509KeyPair(tls.CertFile, tls.KeyFile)
 		return &c, err
 	}
@@ -130,7 +130,7 @@ func (tls *TLSOption) MakeServerTLSConf() (*libtls.Config, error) {
 	if err != nil {
 		return nil, err
 	}
-	tlsConf.GetCertificate = func(clientHello *libtls.ClientHelloInfo) (cert *libtls.Certificate, err error) {
+	tlsConf.GetCertificate = func(_ *libtls.ClientHelloInfo) (cert *libtls.Certificate, err error) {
 		c, err := libtls.LoadX509KeyPair(tls.CertFile, tls.KeyFile)
 		return &c, err
 	}

maelstrom/main.go

@@ -97,7 +97,7 @@ func receiveInit(scanner *bufio.Scanner) error {
 	init := req.(*Message[Init])
 
 	thisNode = init.Body.NodeId
-	allNodes = init.Body.NodesIds
+	allNodes = init.Body.NodesIDs
 
 	slog.Info(
 		"Received init request",

maelstrom/messages.go

@@ -122,7 +122,7 @@ type BaseMessageBody struct {
 type Init struct {
 	BaseMessageBody
 	NodeId   string   `json:"node_id"`
-	NodesIds []string `json:"node_ids"`
+	NodesIDs []string `json:"node_ids"`
 }
 
 type Read struct {

oxia/async_client_impl.go

@@ -184,10 +184,10 @@ func (c *clientImpl) DeleteRange(minKeyInclusive string, maxKeyExclusive string,
 	}
 
 	// If there is no partition key, we will make the request to delete-range on all the shards
-	shardIds := c.shardManager.GetAll()
-	wg := common.NewWaitGroup(len(shardIds))
+	shardIDs := c.shardManager.GetAll()
+	wg := common.NewWaitGroup(len(shardIDs))
 
-	for _, shardId := range shardIds {
+	for _, shardId := range shardIDs {
 		// chInner := make(chan error, 1)
 		c.writeBatchManager.Get(shardId).Add(model.DeleteRangeCall{
 			MinKeyInclusive: minKeyInclusive,
@@ -360,10 +360,10 @@ func (c *clientImpl) List(ctx context.Context, minKeyInclusive string, maxKeyExc
 		}()
 	} else {
 		// Do the list on all shards and aggregate the responses
-		shardIds := c.shardManager.GetAll()
+		shardIDs := c.shardManager.GetAll()
 
-		wg := common.NewWaitGroup(len(shardIds))
-		for _, shardId := range shardIds {
+		wg := common.NewWaitGroup(len(shardIDs))
+		for _, shardId := range shardIDs {
 			shardIdPtr := shardId
 			go func() {
 				defer wg.Done()
@@ -425,10 +425,10 @@ func (c *clientImpl) RangeScan(ctx context.Context, minKeyInclusive string, maxK
 		}()
 	} else {
 		// Do the list on all shards and aggregate the responses
-		shardIds := c.shardManager.GetAll()
-		channels := make([]chan GetResult, len(shardIds))
+		shardIDs := c.shardManager.GetAll()
+		channels := make([]chan GetResult, len(shardIDs))
 
-		for i, shardId := range shardIds {
+		for i, shardId := range shardIDs {
 			shardIdPtr := shardId
 			ch := make(chan GetResult)
 			channels[i] = ch

oxia/internal/metrics/metrics.go

@@ -110,7 +110,7 @@ func (m *Metrics) DecorateGet(get model.GetCall) model.GetCall {
 
 func (m *Metrics) WriteCallback() func(time.Time, *proto.WriteRequest, *proto.WriteResponse, error) {
 	metricContext := m.metricContextFunc("write")
-	return func(executionStart time.Time, request *proto.WriteRequest, response *proto.WriteResponse, err error) {
+	return func(executionStart time.Time, request *proto.WriteRequest, _ *proto.WriteResponse, err error) {
 		ctx, batchStart, _attrs := metricContext(err)
 		m.batchTotalTime.Record(ctx, m.sinceFunc(batchStart), _attrs)
 		m.batchExecTime.Record(ctx, m.sinceFunc(executionStart), _attrs)
@@ -122,7 +122,7 @@ func (m *Metrics) WriteCallback() func(time.Time, *proto.WriteRequest, *proto.Wr
 
 func (m *Metrics) ReadCallback() func(time.Time, *proto.ReadRequest, *proto.ReadResponse, error) {
 	metricContext := m.metricContextFunc("read")
-	return func(executionStart time.Time, request *proto.ReadRequest, response *proto.ReadResponse, err error) {
+	return func(executionStart time.Time, _ *proto.ReadRequest, response *proto.ReadResponse, err error) {
 		ctx, batchStart, attrs := metricContext(err)
 		m.batchTotalTime.Record(ctx, m.sinceFunc(batchStart), attrs)
 		m.batchExecTime.Record(ctx, m.sinceFunc(executionStart), attrs)

oxia/internal/shard_manager.go

@@ -117,11 +117,11 @@ func (s *shardManagerImpl) GetAll() []int64 {
 	s.RLock()
 	defer s.RUnlock()
 
-	shardIds := make([]int64, 0, len(s.shards))
+	shardIDs := make([]int64, 0, len(s.shards))
 	for shardId := range s.shards {
-		shardIds = append(shardIds, shardId)
+		shardIDs = append(shardIDs, shardId)
 	}
-	return shardIds
+	return shardIDs
 }
 
 func (s *shardManagerImpl) Leader(shardId int64) string {

server/assignment_dispatcher_test.go

@@ -324,14 +324,14 @@ func TestShardAssignmentDispatcher_MultipleNamespaces(t *testing.T) {
 	assert.NoError(t, dispatcher.Close())
 }
 
-func newShardAssignment(id int64, leader string, min uint32, max uint32) *proto.ShardAssignment {
+func newShardAssignment(id int64, leader string, minHashInclusive uint32, maxHashInclusive uint32) *proto.ShardAssignment {
 	return &proto.ShardAssignment{
 		Shard:  id,
 		Leader: leader,
 		ShardBoundaries: &proto.ShardAssignment_Int32HashRange{
 			Int32HashRange: &proto.Int32HashRange{
-				MinHashInclusive: min,
-				MaxHashInclusive: max,
+				MinHashInclusive: minHashInclusive,
+				MaxHashInclusive: maxHashInclusive,
 			},
 		},
 	}

server/auth/interceptor.go

@@ -43,21 +43,21 @@ type GrpcAuthenticationDelegator struct {
 }
 
 func (delegator *GrpcAuthenticationDelegator) GetUnaryInterceptor() grpc.UnaryServerInterceptor {
-	return func(ctx context.Context, req any, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (any, error) {
+	return func(ctx context.Context, req any, _ *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (any, error) {
 		_, err := delegator.validate(ctx, delegator.provider)
 		if err != nil {
-			return nil, status.Errorf(codes.Unauthenticated, err.Error())
+			return nil, status.Error(codes.Unauthenticated, err.Error())
 		}
 		// todo: set username to metadata to support authorization
 		return handler(ctx, req)
 	}
 }
 
 func (delegator *GrpcAuthenticationDelegator) GetStreamInterceptor() grpc.StreamServerInterceptor {
-	return func(srv any, ss grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error {
+	return func(srv any, ss grpc.ServerStream, _ *grpc.StreamServerInfo, handler grpc.StreamHandler) error {
 		_, err := delegator.validate(ss.Context(), delegator.provider)
 		if err != nil {
-			return status.Errorf(codes.Unauthenticated, err.Error())
+			return status.Error(codes.Unauthenticated, err.Error())
 		}
 		// todo: set username to metadata to support authorization
 		return handler(srv, ss)

server/session_manager_test.go

@@ -106,7 +106,7 @@ func (m mockWriteBatch) DeleteRange(_, _ string) error {
 }
 
 func (m mockWriteBatch) KeyRangeScan(_, _ string) (kv.KeyIterator, error) {
-	return nil, nil
+	return nil, kv.ErrKeyNotFound
 }
 
 func (m mockWriteBatch) Commit() error {

server/wal/treemap.go

@@ -58,7 +58,7 @@ func (m *treeMap[K, V]) Size() int {
 
 func (m *treeMap[K, V]) Keys() []K {
 	keys := make([]K, 0, m.tree.Size())
-	m.Each(func(k K, v V) bool {
+	m.Each(func(k K, _ V) bool {
 		keys = append(keys, k)
 		return true
 	})

server/wal/wal_ro_segment.go

@@ -211,7 +211,7 @@ func (r *readOnlySegmentsGroup) Close() error {
 	defer r.Unlock()
 
 	var err error
-	r.openSegments.Each(func(id int64, segment common.RefCount[ReadOnlySegment]) bool {
+	r.openSegments.Each(func(_ int64, segment common.RefCount[ReadOnlySegment]) bool {
 		err = multierr.Append(err, segment.(io.Closer).Close())
 		return true
 	})
@@ -293,7 +293,7 @@ func (r *readOnlySegmentsGroup) PollHighestSegment() (common.RefCount[ReadOnlySe
 	defer r.Unlock()
 
 	if r.allSegments.Empty() {
-		return nil, nil
+		return nil, nil // nolint: nilnil
 	}
 
 	offset, _ := r.allSegments.Max()