Update README on swagger-ui #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
Nov 14, 2019
emonddr
approved these changes
Nov 14, 2019
dhmlau
commented
Nov 19, 2019
There was a problem hiding this comment.
According to our discussion, I'll only cover the security vulnerability https://www.npmjs.com/advisories/985 in this PR.
|
I added a new commit 8a0545c to improve the messaging a bit and describe two more vulnerabilities that are known to not affect our API Explorer. WDYT? |
LGTM. Let me squash the commit. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update README to explain we're not affected by the swagger-ui security vulnerability.
Related issues
#263 (comment)
https://github.com/strongloop-internal/scrum-apex/issues/432
Checklist
guide