-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest dependencies #26
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ results | |
npm-debug.log | ||
node_modules | ||
coverage | ||
.nyc_output/ | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
lib-cov | ||
*.seed | ||
*.log | ||
*.csv | ||
*.dat | ||
*.out | ||
*.pid | ||
*.gz | ||
|
||
pids | ||
logs | ||
results | ||
|
||
npm-debug.log | ||
node_modules | ||
coverage | ||
.jshintrc | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copied from .gitignore, then adding a few things that probably shouldn't be in the tarfile sent to the npm repo. |
||
.travis.yml | ||
.nyc_output/ | ||
test/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some people really like their tests in the package, but if the goal here is "small and tight" then they should be excluded IMO. |
||
CHANGES.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd be totally fine if you prefer CHANGES.md in the npm package. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
language: node_js | ||
node_js: | ||
- "6" | ||
- "8" | ||
- "10" | ||
- "14" | ||
- "16" | ||
- "18" | ||
- "19" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm 90% sure that travis isn't going to run. Assuming it doesn't, I'd be happy to add GitHub actions to the repo. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,8 +6,7 @@ | |
"main": "index.js", | ||
"scripts": { | ||
"pretest": "jshint *.js test", | ||
"test": "istanbul test -- _mocha -R spec", | ||
"posttest": "test -z $npm_config_coverage || istanbul report" | ||
"test": "nyc -r lcov _mocha -R spec" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. istanbul is deprecated, as is npm_config_coverage, which doesn't get set anymore. nyc is fast enough that it doesn't add enough overhead to the test loop to matter. |
||
}, | ||
"repository": { | ||
"type": "git", | ||
|
@@ -18,15 +17,15 @@ | |
"email": "miroslav@strongloop.com" | ||
}, | ||
"dependencies": { | ||
"truncate": "^2.0.1" | ||
"truncate": "^3.0.0" | ||
}, | ||
"devDependencies": { | ||
"mocha": "~1.17.1", | ||
"jshint": "~2.4.3", | ||
"istanbul": "~0.2.4", | ||
"chai": "~1.8.1" | ||
"chai": "~4.3.7", | ||
"jshint": "~2.13.6", | ||
"mocha": "~10.2.0", | ||
"nyc": "15.1.0" | ||
}, | ||
"engines": { | ||
"node": ">=0.8.0" | ||
"node": ">=14" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the breaking change, requiring a major version bump IMO. See https://github.com/nodejs/Release for justification. |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from the istanbul->nyc change