Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include-what-you-use and removed (some few) unnecessary includes. #146

Open
wants to merge 3 commits into
base: frame-parallel
Choose a base branch
from

Conversation

fancycode
Copy link
Member

Be explicit with the includes and don't rely on "magic" by the compiler or some other files to include stuff.

Should we check this by Travis?

Also what do you think about using a consistent format for includes? Sometimes, headers are references as libde265/filename.h, sometimes only as filename.h (and sometimes both in the same file). For consistency, we should imho always use libde265/filename.h.

@farindk
Copy link
Contributor

farindk commented Jan 17, 2017

Always using libde265/filename.h is fine for me.

Includes can be checked by Traves, but it should be a non-essential test.

@fancycode
Copy link
Member Author

The includes are updated now. I will do the Travis integration in a separate PR but already added the cpplint configuration.

Manual checking can be done using

$ find libde265 -name "*.cc" -o -name "*.h" | sort -u | xargs cpplint.py

Feel free to merge if everything is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants