Skip to content

Fixed #1111 Add branching logic for sdp #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NimaSarajpoor wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

Fixed #1111 Add branching logic for sdp #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2221b1
add branching logic to sdp func in core
NimaSarajpoor Aug 25, 2026
5450557
add test function to improve coverage
NimaSarajpoor Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stumpy/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"STUMPY_MAX_P_NORM_DISTANCE": np.finfo(np.float64).max,
"STUMPY_MAX_DISTANCE": np.sqrt(np.finfo(np.float64).max),
"STUMPY_EXCL_ZONE_DENOM": 4,
"STUMPY_NJIT_SDP_Q_LENGTH": 128, # 2 ** 7
"STUMPY_FASTMATH_TRUE": True,
"STUMPY_FASTMATH_FLAGS": {"nsz", "arcp", "contract", "afn", "reassoc"},
"STUMPY_FASTMATH_FASTMATH._ADD_ASSOC": True,
Expand All @@ -38,6 +39,7 @@
STUMPY_MAX_P_NORM_DISTANCE = _STUMPY_DEFAULTS["STUMPY_MAX_P_NORM_DISTANCE"]
STUMPY_MAX_DISTANCE = _STUMPY_DEFAULTS["STUMPY_MAX_DISTANCE"]
STUMPY_EXCL_ZONE_DENOM = _STUMPY_DEFAULTS["STUMPY_EXCL_ZONE_DENOM"]
STUMPY_NJIT_SDP_Q_LENGTH = _STUMPY_DEFAULTS["STUMPY_NJIT_SDP_Q_LENGTH"]
STUMPY_FASTMATH_TRUE = _STUMPY_DEFAULTS["STUMPY_FASTMATH_TRUE"]
STUMPY_FASTMATH_FLAGS = _STUMPY_DEFAULTS["STUMPY_FASTMATH_FLAGS"]

Expand Down
11 changes: 10 additions & 1 deletion stumpy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,16 @@ def sliding_dot_product(Q, T):
output : numpy.ndarray
Sliding dot product between `Q` and `T`.
"""
return sdp._sliding_dot_product(Q, T)
if len(Q) == len(T):
out = np.array([np.dot(Q, T)])
elif len(Q) <= config.STUMPY_NJIT_SDP_Q_LENGTH:
out = sdp._njit_sliding_dot_product(Q, T)
elif sdp.PYFFTW_IS_AVAILABLE: # pragma: no cover
out = sdp._pyfftw_sliding_dot_product(Q, T)
else:
out = sdp._sliding_dot_product(Q, T)

return out


@njit(
Expand Down
10 changes: 10 additions & 0 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,16 @@ def test_sliding_dot_product(Q, T):
npt.assert_allclose(cmp_mp, ref_mp, atol=1.5e-07)


def test_sliding_dot_product_large_Q():
# Set len(T) > len(Q) > config.STUMPY_NJIT_SDP_Q_LENGTH,
# so that it triggers a certain code flow
Q = rng.RNG.rand(config.STUMPY_NJIT_SDP_Q_LENGTH + 1)
T = rng.RNG.rand(config.STUMPY_NJIT_SDP_Q_LENGTH + 2)
ref_mp = naive.rolling_window_dot_product(Q, T)
cmp_mp = core.sliding_dot_product(Q, T)
npt.assert_allclose(cmp_mp, ref_mp, atol=1.5e-07)


def test_welford_nanvar():
T = rng.RNG.rand(64)
m = 10
Expand Down
Loading